Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct left rotor translation which was wrong only for object viewer. #59

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

jmbau
Copy link
Collaborator

@jmbau jmbau commented Aug 1, 2024

I recently saw that V-22 left rotor position was wrong in model viewer (Free flight -> Aircraft -> Details...).
After some tests and look at sar2 code, I understood that moving parts as rotor, gears, ailerons, doors, and so on..., are not drawn in model viewer as in game.
In game, parts are drawn using rotor_new, landing_gear_new, aileron_left_new, rescue_door_new, and so on... parameters, but in model viewer, they are only drawn with translate and rotate parameters. It is why x, y, z and h, p, b rotor_new values are always 'copied and pasted' to translate and rotate values (example: hh60.3d file):
...
# Tail rotor
# blades x y z h p b r prop_wash? flw_con? blur?
rotor_new 2 0.3 -9.1 0.6 0.0 0.0 80.0 1.5 0 0 1
# r g b a
rotor_blur_color 0.15 0.15 0.15 0.75
begin_model rotor
#$model_flags
translate 0.300000 -9.100000 0.600000
rotate 0.000000 0.000000 80.000000
# Struts to blades
...
V-22 left rotor is an exception, it don't work in model viewer if translate 'z' value is copied from rotor_new 'z' value: value must be modified.

I don't know if it is possible that copying 'z' value works for V-22 left rotor, but if yes, it would certainly need to modify some primitives in addition to rotor_new values.

@hsanjuan
Copy link
Member

hsanjuan commented Sep 3, 2024

:) I love your attention to detail

@hsanjuan hsanjuan merged commit f311377 into master Sep 3, 2024
1 check passed
@hsanjuan hsanjuan deleted the v22_correction branch September 3, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants